Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add memo in ics20 packet data (cosmos#2411) #2415

Closed
wants to merge 3 commits into from
Closed

chore: add memo in ics20 packet data (cosmos#2411) #2415

wants to merge 3 commits into from

Conversation

alizahidraja
Copy link
Contributor

@alizahidraja alizahidraja commented Sep 27, 2022 •
edited
Loading

Description

Add memo field in ics20 packet data proto
closes: #2411

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alizahidraja
Copy link
Contributor Author

Full disclosure: I couldn't manage to update packet.pb.go file from cli (generate code from proto file), so for now, I updated the file manually (not ideal, especially when the file starts with "do not edit")

I updated the corresponding code in keeper & types for transfer; if someone can help me generate the packet.pb.go file from cli, that would be great!

@crodriguezvega
Copy link
Contributor

Hi @alizahidraja. Thanks a lot for picking this up. Unfortunately, there was already a couple of branches opened here and here implementing the changes. I am sorry that the issue was not properly assigned and gave the impression that it was available. We should have assigned it immediately to the person that was already working on it.

Is it ok if we close this PR then? I am very sorry for the confusion. If you're interested in working on ibc-go issues, please take a look at our good first issues and help wanted issues. We hope you can find one interesting for you; otherwise, let us know and I am sure we will be able to find something else!

@alizahidraja
Copy link
Contributor Author

Hey @crodriguezvega! No worries at all :D

And yes, I will take a look at the ones with the mentioned tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Metadata field in ICS20 Packet data proto
2 participants
@alizahidraja @crodriguezvega